ec4ac49ebb723349463504fdb723109575072772,uportal-war/src/test/java/org/jasig/portal/portlet/container/properties/RequestPropertiesManagerBrokerTest.java,RequestPropertiesManagerBrokerTest,testSetProperties,#,96

Before Change


        
        
        this.requestPropertiesManagerBroker.setResponseProperty(request, portletWindow, "prop.A", "prop.A.1");
        final Map<String, String[]> expected1 = Collections.singletonMap("prop.A", new String[] { "prop.A.1" });
        
        Map<String, String[]> properties = this.requestPropertiesManagerBroker.getRequestProperties(request, portletWindow);
        validateProperties(expected1, properties);
        
        Map<String, String[]> properties1 = delegateManager1.getRequestProperties(request, portletWindow);
        validateProperties(expected1, properties1);
        
        Map<String, String[]> properties2 = delegateManager2.getRequestProperties(request, portletWindow);
        validateProperties(expected1, properties2);
        
        
        
        this.requestPropertiesManagerBroker.setResponseProperty(request, portletWindow, "prop.A", "prop.A.2");
        final Map<String, String[]> expected2 = Collections.singletonMap("prop.A", new String[] { "prop.A.2" });
        
        properties = this.requestPropertiesManagerBroker.getRequestProperties(request, portletWindow);
        validateProperties(expected2, properties);
        
        properties1 = delegateManager1.getRequestProperties(request, portletWindow);
        validateProperties(expected2, properties1);
        
        properties2 = delegateManager2.getRequestProperties(request, portletWindow);
        validateProperties(expected2, properties2);

After Change


    public void testSetProperties() {
        final MockHttpServletRequest request = new MockHttpServletRequest();
        
        final IPortletWindow portletWindow = EasyMock.createMock(IPortletWindow.class);
        EasyMock.replay(portletWindow);
        
        final MockRequestPropertiesManager delegateManager1 = new MockRequestPropertiesManager();
        delegateManager1.setOrder(Ordered.HIGHEST_PRECEDENCE);
        final MockRequestPropertiesManager delegateManager2 = new MockRequestPropertiesManager();
        delegateManager2.setOrder(Ordered.LOWEST_PRECEDENCE);
        
        this.requestPropertiesManagerBroker.setPropertiesManagers(ImmutableList.of(delegateManager1, delegateManager2));
        
        
        
        this.requestPropertiesManagerBroker.setResponseProperty(request, portletWindow, "prop.A", "prop.A.1");
        final Map<String, List<String>> expected1 = Collections.singletonMap("prop.A", Collections.singletonList("prop.A.1"));
        
        MultivaluedMapPopulator<String, String> multivaluedMapPopulator = new MultivaluedMapPopulator<String, String>();
        this.requestPropertiesManagerBroker.populateRequestProperties(request, portletWindow, multivaluedMapPopulator);
        assertEquals(expected1, multivaluedMapPopulator.getMap());
        
        multivaluedMapPopulator = new MultivaluedMapPopulator<String, String>();
        delegateManager1.populateRequestProperties(request, portletWindow, multivaluedMapPopulator);
        assertEquals(expected1, multivaluedMapPopulator.getMap());
        
        multivaluedMapPopulator = new MultivaluedMapPopulator<String, String>();
        delegateManager2.populateRequestProperties(request, portletWindow, multivaluedMapPopulator);
        assertEquals(Collections.EMPTY_MAP, multivaluedMapPopulator.getMap());
        
        
        
        this.requestPropertiesManagerBroker.setResponseProperty(request, portletWindow, "prop.A", "prop.A.2");
        final Map<String, List<String>> expected2 = Collections.<String, List<String>>singletonMap("prop.A", ImmutableList.of("prop.A.2"));
        
        multivaluedMapPopulator = new MultivaluedMapPopulator<String, String>();
        this.requestPropertiesManagerBroker.populateRequestProperties(request, portletWindow, multivaluedMapPopulator);
        assertEquals(expected2, multivaluedMapPopulator.getMap());
        
        multivaluedMapPopulator = new MultivaluedMapPopulator<String, String>();
        delegateManager1.populateRequestProperties(request, portletWindow, multivaluedMapPopulator);
        assertEquals(expected2, multivaluedMapPopulator.getMap());
        
        multivaluedMapPopulator = new MultivaluedMapPopulator<String, String>();
        delegateManager2.populateRequestProperties(request, portletWindow, multivaluedMapPopulator);
        assertEquals(Collections.EMPTY_MAP, multivaluedMapPopulator.getMap());
    }