f3a00a0a880de3a886dd4dbbc92ae71bfde21158,opennms-provision/opennms-provisiond/src/main/java/org/opennms/netmgt/provision/service/DefaultProvisionService.java,DefaultProvisionService,addMonitoredService,#number#String#String#,269
Before Change
public OnmsMonitoredService addMonitoredService(Integer nodeId, String ipAddress, String svcName) {
OnmsIpInterface iface = m_ipInterfaceDao.findByNodeIdAndIpAddress(nodeId, ipAddress);
assertNotNull(iface, "could not find interface with nodeid %d and ipAddr %s", nodeId, ipAddress);
OnmsServiceType svcType = m_serviceTypeDao.findByName(svcName);
if (svcType == null) {
svcType = new OnmsServiceType(svcName);
m_serviceTypeDao.save(svcType);
}
OnmsMonitoredService svc = iface.getMonitoredServiceByServiceType(svcName);
if (svc != null) {
m_monitoredServiceDao.saveOrUpdate(svc);
} else {
// this adds the service to the interface as a side effect
svc = new OnmsMonitoredService(iface, svcType);
svc.setStatus("A");
m_ipInterfaceDao.saveOrUpdate(iface);
AddEventVisitor visitor = new AddEventVisitor(m_eventForwarder);
svc.visit(visitor);
}
return svc;
}
public void clearCache() {
After Change
public OnmsMonitoredService addMonitoredService(Integer nodeId, String ipAddress, String svcName) {
OnmsIpInterface iface = m_ipInterfaceDao.findByNodeIdAndIpAddress(nodeId, ipAddress);
assertNotNull(iface, "could not find interface with nodeid %d and ipAddr %s", nodeId, ipAddress);
return addMonitoredService(iface, svcName);
}
public void clearCache() {