1dff858e98eba97b6a3a536d91e65d6c95949a9e,src/org/pentaho/di/trans/steps/salesforceinsert/SalesforceInsert.java,SalesforceInsert,flushBuffers,#,156
Before Change
// there were errors during the create call, go through the
// errors
// array and write them to the screen
boolean sendToErrorRow=false;
String errorMessage = null;
if (getStepMeta().isDoingErrorHandling())
{
sendToErrorRow = true;
errorMessage = "";
for (int i = 0; i < data.saveResult[j].getErrors().length; i++) {
// get the next error
com.salesforce.soap.partner.Error err = data.saveResult[j].getErrors()[i];
errorMessage+= BaseMessages.getString(PKG, "SalesforceInsert.Error.FlushBuffer",
new Integer(j), err.getStatusCode(), err.getMessage());
}
}
else
{
if(log.isDebug()) logDebug(BaseMessages.getString(PKG, "SalesforceInsert.ErrorFound"));
//for (int i = 0; i < data.saveResult[j].getErrors().length; i++) {
// Only show the first error
//
com.salesforce.soap.partner.Error err = data.saveResult[j].getErrors()[0];
throw new KettleException(BaseMessages.getString(PKG, "SalesforceInsert.Error.FlushBuffer",
new Integer(j), err.getStatusCode(), err.getMessage()));
// } // for error messages
}
if (sendToErrorRow) {
// Simply add this row to the error row
if(log.isDetailed()) logDetailed(BaseMessages.getString(PKG, "SalesforceInsert.PassingRowToErrorStep"));
putError(getInputRowMeta(), data.outputBuffer[j], 1, errorMessage, null, "SalesforceInsert001");
}
}
After Change
// errors
// array and write them to the screen
if (!getStepMeta().isDoingErrorHandling()) {
if(log.isDebug()) logDebug(BaseMessages.getString(PKG, "SalesforceInsert.ErrorFound"));
// Only show the first error
//
com.sforce.soap.partner.Error err = data.saveResult[j].getErrors()[0];
throw new KettleException(BaseMessages.getString(PKG, "SalesforceInsert.Error.FlushBuffer",
new Integer(j), err.getStatusCode(), err.getMessage()));
}
String errorMessage="";
for (int i = 0; i < data.saveResult[j].getErrors().length; i++) {
// get the next error
com.sforce.soap.partner.Error err = data.saveResult[j].getErrors()[i];
errorMessage+= BaseMessages.getString(PKG, "SalesforceInsert.Error.FlushBuffer",
new Integer(j), err.getStatusCode(), err.getMessage());
}
// Simply add this row to the error row
if(log.isDetailed()) logDetailed(BaseMessages.getString(PKG, "SalesforceInsert.PassingRowToErrorStep"));
putError(getInputRowMeta(), data.outputBuffer[j], 1, errorMessage, null, "SalesforceInsert001");
}