9399b60e6d83d549105783e60c2d6a6325c2af88,src/main/java/com/continuuity/data/operation/executor/remote/OperationExecutorClient.java,OperationExecutorClient,execute,#Delete#,383

Before Change


  @Override
  public boolean execute(Delete delete) {

    MetricsHelper helper = new MetricsHelper(this.metrics, this.getClass(),
        Constants.METRIC_REQUESTS, Constants.METRIC_DELETE_REQUESTS);

    try {
      if (Log.isDebugEnabled())
        Log.debug("Received " + delete);

      TDelete tDelete = wrap(delete);

      if (Log.isDebugEnabled())
        Log.debug("Sending " + tDelete);

      boolean result = client.delet(tDelete);

      if (Log.isDebugEnabled())
        Log.debug("Result of TDelete: " + result);

      helper.finish(Constants.METRIC_SUCCESS, Constants.METRIC_DELETE_LATENCY);
      return result;

    } catch (TException e) {
      helper.finish(Constants.METRIC_FAILURE, null);
      Log.error("Thrift Call for Delete for key '" + new String(delete.getKey())
          + "' failed with message: " + e.getMessage());
      return false; // TODO execute() must be able to return an error

After Change


  @Override
  public boolean execute(Delete delete) {

    MetricsHelper helper = newHelper(
        Constants.METRIC_DELETE_REQUESTS,
        Constants.METRIC_DELETE_LATENCY);

    try {
      if (Log.isDebugEnabled())
        Log.debug("Received " + delete);

      TDelete tDelete = wrap(delete);

      if (Log.isDebugEnabled())
        Log.debug("Sending " + tDelete);

      boolean success = client.delet(tDelete);

      if (Log.isDebugEnabled())
        Log.debug("Result of TDelete: " + success);

      helper.finish(success);
      return success;

    } catch (TException e) {