174a9d01c265c9b92fe44a4c3609199a033507cf,software/base/src/main/java/brooklyn/entity/basic/lifecycle/CommonCommands.java,CommonCommands,installPackage,#Map#String#,147

Before Change


                "echo apt-get exists, doing update",
                "export DEBIAN_FRONTEND=noninteractive",
                sudo("apt-get update"),
                sudo(formatIfNotNull("apt-get install -y --allow-unauthenticated %s", getFlag(flags, "apt", packageDefaultName)))));
        commands.add(exists("yum", sudo(formatIfNotNull("yum -y --nogpgcheck install %s", getFlag(flags, "yum", packageDefaultName)))));
        commands.add(exists("brew", formatIfNotNull("brew install %s", getFlag(flags, "brew", packageDefaultName))));
        commands.add(exists("port", sudo(formatIfNotNull("port install %s", getFlag(flags, "port", packageDefaultName)))));

After Change


    public static String installPackage(Map flags, String packageDefaultName) {
        String ifmissing = (String) flags.get("onlyifmissing");
        
        String aptInstall = formatIfNotNull("apt-get install -y --allow-unauthenticated %s", getFlag(flags, "apt", packageDefaultName));
        String yumInstall = formatIfNotNull("yum -y --nogpgcheck install %s", getFlag(flags, "yum", packageDefaultName));
        String brewInstall = formatIfNotNull("brew install %s", getFlag(flags, "brew", packageDefaultName));
        String portInstall = formatIfNotNull("port install %s", getFlag(flags, "port", packageDefaultName));
        
        List<String> commands = new LinkedList<String>();
        if (ifmissing != null) commands.add(format("which %s", ifmissing));
        commands.add(exists("apt-get",
                "echo apt-get exists, doing update",
                "export DEBIAN_FRONTEND=noninteractive",
                sudo("apt-get update"), 
                sudo(aptInstall)));
        commands.add(exists("yum", sudo(yumInstall)));
        commands.add(exists("brew", brewInstall));
        commands.add(exists("port", sudo(portInstall)));