582ffa58baa86120ae9bc70fc77a1b412d2a303f,findbugs/src/java/edu/umd/cs/findbugs/detect/SynchronizationOnSharedBuiltinConstant.java,SynchronizationOnSharedBuiltinConstant,sawOpcode,#number#,54

Before Change


			String signature = top.getSignature();
			Object constant = top.getConstant();
			if (signature.equals("Ljava/lang/String;") && constant instanceof String) 
				bugReporter.reportBug(new BugInstance(this, "DL_SYNCHRONIZATION_ON_SHARED_CONSTANT", NORMAL_PRIORITY)
				.addClassAndMethod(this).addString((String)constant).addSourceLine(this));
			else if (badSignatures.contains(signature)) {
				boolean isBoolean = signature.equals("Ljava/lang/Boolean;");
				XField field = top.getXField();

After Change


			String signature = top.getSignature();
			Object constant = top.getConstant();
			if (signature.equals("Ljava/lang/String;") && constant instanceof String) {
				BugInstance bug = new BugInstance(this, "DL_SYNCHRONIZATION_ON_SHARED_CONSTANT", NORMAL_PRIORITY).addClassAndMethod(this);

				String value = (String) constant;
				if (identified.matcher(value).matches())
					bug.addString(value).describe(StringAnnotation.STRING_CONSTANT_ROLE);
				
				bugReporter.reportBug(bug.addSourceLine(this));
			} else if (badSignatures.contains(signature)) {
				boolean isBoolean = signature.equals("Ljava/lang/Boolean;");
				XField field = top.getXField();