5ef0c96e7008e08a763df6f6a441b46a7d2f8634,server/src/com/cloud/storage/upload/UploadMonitorImpl.java,UploadMonitorImpl,cleanupStorage,#,469

Before Change


                s_logger.debug("Sending deletion of extract URL "+extractJob.getUploadUrl());
                // Would delete the symlink for the Type and if Type == VOLUME then also the volume
                DeleteEntityDownloadURLCommand cmd = new DeleteEntityDownloadURLCommand(path, extractJob.getType(),extractJob.getUploadUrl());
                HostVO ssvm = _agentMgr.getSSAgent(ApiDBUtils.findHostById(extractJob.getHostId()));
                if( ssvm == null ) {
                	s_logger.warn("There is no secondary storage VM for secondary storage host " + extractJob.getHostId());
                	continue;

After Change


        for (UploadVO extractJob : extractJobs){
            if( getTimeDiff(extractJob.getLastUpdated()) > EXTRACT_URL_LIFE_LIMIT_IN_SECONDS ){                           
                String path = extractJob.getInstallPath();
                HostVO secStorage = ApiDBUtils.findHostById(extractJob.getHostId());
                s_logger.debug("Sending deletion of extract URL "+extractJob.getUploadUrl());
                // Would delete the symlink for the Type and if Type == VOLUME then also the volume
                DeleteEntityDownloadURLCommand cmd = new DeleteEntityDownloadURLCommand(path, extractJob.getType(),extractJob.getUploadUrl(), secStorage.getParent());
                HostVO ssvm = _agentMgr.getSSAgent(secStorage);
                if( ssvm == null ) {
                	s_logger.warn("There is no secondary storage VM for secondary storage host " + extractJob.getHostId());
                	continue;