98ab5a6985e6da9d25cae3a37d988edab0f3fd62,plugins/IntentionPowerPak/src/com/siyeh/ipp/equality/ObjectEqualityPredicate.java,ObjectEqualityPredicate,satisfiedBy,#PsiElement#,26
Before Change
if(!(element instanceof PsiBinaryExpression)){
return false;
}
if(ErrorUtil.containsError(element)){
return false;
}
final PsiBinaryExpression expression = (PsiBinaryExpression) element;
final PsiJavaToken sign = expression.getOperationSign();
final IElementType tokenType = sign.getTokenType();
if(!tokenType.equals(JavaTokenType.NE) &&
!tokenType.equals(JavaTokenType.EQEQ)){
return false;
}
final PsiExpression lhs = expression.getLOperand();
final String lhsText = lhs.getText();
if (PsiKeyword.NULL.equals(lhsText)) {
return false;
}
final PsiType lhsType = lhs.getType();
if(lhsType == null){
return false;
}
final PsiExpression rhs = expression.getROperand();
if(rhs == null){
return false;
}
final String rhsText = rhs.getText();
if (PsiKeyword.NULL.equals(rhsText)) {
return false;
}
final PsiType rhsType = rhs.getType();
if(rhsType == null){
return false;
}
return !TypeConversionUtil.isPrimitiveAndNotNull(lhsType) &&
!TypeConversionUtil.isPrimitiveAndNotNull(rhsType);
}
}
After Change
if(rhsType == null){
return false;
}
if (TypeConversionUtil.isPrimitiveAndNotNull(lhsType) ||
TypeConversionUtil.isPrimitiveAndNotNull(rhsType)) {
return false;
}
return !ErrorUtil.containsError(element);
}
}