e3e705b429b415a842f3a1abab7c902c19351d19,server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/measure/BestValueOptimization.java,BestValueOptimization,hasOnlyZeroVariations,#MeasureVariations#,71

Before Change


      && (!variations.hasVariation2() || NumberUtils.compare(variations.getVariation2(), 0.0) == 0)
      && (!variations.hasVariation3() || NumberUtils.compare(variations.getVariation3(), 0.0) == 0)
      && (!variations.hasVariation4() || NumberUtils.compare(variations.getVariation4(), 0.0) == 0)
      && (!variations.hasVariation5() || NumberUtils.compare(variations.getVariation5(), 0.0) == 0);
  }

  private static boolean isBestValue(Measure measure, Double bestValue) {

After Change


      && (!variations.hasVariation2() || isVariationEmptyOrBestValue(variations.getVariation2(), bestValue))
      && (!variations.hasVariation3() || isVariationEmptyOrBestValue(variations.getVariation3(), bestValue))
      && (!variations.hasVariation4() || isVariationEmptyOrBestValue(variations.getVariation4(), bestValue))
      && (!variations.hasVariation5() || isVariationEmptyOrBestValue(variations.getVariation5(), bestValue));
  }

  private static boolean isVariationEmptyOrBestValue(double variation, Double bestValue) {