69fd2a05c4752124bf460ac71a83178925ae1ef7,opennms-webapp/src/main/java/org/opennms/web/controller/inventory/AdminRancidCloginController.java,AdminRancidCloginController,onSubmit,#HttpServletRequest#HttpServletResponse#Object#BindException#,28

Before Change


        
        AdminRancidCloginCommClass bean = (AdminRancidCloginCommClass) command;
        
        log().debug("AdminRancidCloginController ModelAndView onSubmit following changes"+
                    "userID ["+ bean.getUserID() +"] "+
                    "pass [" + bean.getPass() +"] "+
                    "enpass [" + bean.getEnpass()+"] "+
                    "loginM [" + bean.getLoginM()+"] "+
                    "autoE [" + bean.getAutoE()+"] "+
                    "groupName [" + bean.getGroupName()+"] "+
                    "deviceName [" + bean.getDeviceName() + "] "); 

        ConnectionProperties cp = new ConnectionProperties(m_rwsConfig.getBaseUrl().getServer_url(),m_rwsConfig.getBaseUrl().getDirectory(),m_rwsConfig.getBaseUrl().getTimeout());

        RancidNodeAuthentication rna = RWSClientApi.getRWSAuthNode(cp, bean.getDeviceName());
        rna.setUser(bean.getUserID());
        rna.setPassword(bean.getPass());
        rna.setConnectionMethod(bean.getLoginM());
        rna.setEnablePass(bean.getAutoE());
        boolean autoe = false;
        if (bean.getAutoE().compareTo("1")==0) {
            autoe = true;
        }
        rna.setAutoEnable(autoe);
        RWSClientApi.createOrUpdateRWSAuthNode(cp,rna);
        log().debug("AdminRancidCloginController ModelAndView onSubmit changes submitted");


        

After Change


        
        AdminRancidCloginCommClass bean = (AdminRancidCloginCommClass) command;
        
        boolean done = m_inventoryService.updateClogin(bean.getDeviceName(), bean.getGroupName(), bean.getUserID(), bean.getPass(),
                                        bean.getEnpass(), bean.getLoginM(), bean.getAutoE());
        if (!done){
            log().debug("AdminRancidCloginController error on submitting cLogin changes");
        }
        String redirectURL = request.getHeader("Referer");
        response.sendRedirect(redirectURL);