9fb60e06b03e6235cf136f26af37f2086aa57fb1,python/src/com/jetbrains/python/actions/SimplifyBooleanCheckQuickFix.java,SimplifyBooleanCheckQuickFix,applyFix,#Project#ProblemDescriptor#,42

Before Change


      final PyExpression leftExpression = binaryExpression.getLeftExpression();
      final PyExpression rightExpression = binaryExpression.getRightExpression();
      boolean positiveCondition = !TokenSet.create(PyTokenTypes.NE, PyTokenTypes.NE_OLD).contains(binaryExpression.getOperator());
      positiveCondition ^= isFalse(leftExpression) || isFalse(rightExpression);
      if (isTrue(leftExpression) || isFalse(leftExpression)) {
        resultExpression = rightExpression;
      } else {

After Change


      final PyExpression leftExpression = binaryExpression.getLeftExpression();
      final PyExpression rightExpression = binaryExpression.getRightExpression();
      boolean positiveCondition = !TokenSet.create(PyTokenTypes.NE, PyTokenTypes.NE_OLD).contains(binaryExpression.getOperator());
      positiveCondition ^= isFalse(leftExpression) || isFalse(rightExpression) || isNull(rightExpression) || isNull(leftExpression)
                           || isEmpty(rightExpression) || isEmpty(leftExpression);
      if (isTrue(leftExpression) || isFalse(leftExpression) || isNull(leftExpression) || isEmpty(leftExpression)) {
        resultExpression = rightExpression;