e53e5e64d1a0f9911b670d67d6e014b210a54924,opennms-services/src/main/java/org/opennms/netmgt/capsd/snmp/SnmpStore.java,SnmpStore,storeResult,#SnmpObjId#SnmpInstId#SnmpValue#,78
Before Change
for(int i = 0; i < ms_elemList.length; i++) {
NamedSnmpVar var = ms_elemList[i];
if (base.equals(var.getSnmpObjId())) {
log().debug("Storing Result: alias: "+var.getAlias()+" ["+base+"].["+inst+"] = "+toLogString(val));
putValue(var.getAlias(), val);
}
}
After Change
for(int i = 0; i < ms_elemList.length; i++) {
NamedSnmpVar var = ms_elemList[i];
if (base.equals(var.getSnmpObjId())) {
if (val.isError()) {
log().error("storeResult: got an error for alias "+var.getAlias()+" ["+base+"].["+inst+"], but we should only be getting non-errors: " + val);
} else if (val.isEndOfMib()) {
log().debug("storeResult: got endOfMib for alias "+var.getAlias()+" ["+base+"].["+inst+"], not storing");
} else {
SnmpValueType type = SnmpValueType.valueOf(val.getType());
log().debug("Storing Result: alias: "+var.getAlias()+" ["+base+"].["+inst+"] = " + (type == null ? "Unknown" : type.getDisplayString()) + ": "+toLogString(val));
putValue(var.getAlias(), val);
}
}