b765812ffc4fd5a26a6074c42dba71d85a3cf7e4,h2o-algos/src/main/java/hex/schemas/KMeansHandler.java,KMeansHandler,train,#number#KMeansV2#,20
Before Change
// TODO: also add a score method in the new ModelBuilderHandler superclass
public KMeansV2 train(int version, KMeansV2 s) {
KMeans builder = s.createAndFillImpl();
KMeansParameters parms = builder._parms;
assert parms != null; /* impl._job = */
builder.trainModel();
s.job = (JobV2) Schema.schema(version, Job.class).fillFromImpl(builder);
return s;
}
}
After Change
// TODO: move this into a new ModelBuilderHandler superclass
// TODO: also add a score method in the new ModelBuilderHandler superclass
public Schema train(int version, KMeansV2 s) {
KMeans builder = s.createAndFillImpl();
if (builder.error_count() > 0)
return Schema.schema(version, builder).fillFromImpl(builder);
assert builder._parms != null; /* impl._job = */
Job j = builder.trainModel();
return new JobsV2().fillFromImpl(new JobsHandler.Jobs(j)); // TODO: version
}
}