73c364e6776f0990416eb8675f9530e9f9b0ba7b,community/test/java/slavetest/AbstractHaTest.java,AbstractHaTest,verifyNode,#Node#Node#VerifyDbContext#VerifyDbContext#,57

Before Change


    private static void verifyNode( Node node, Node otherNode,
            VerifyDbContext refDb, VerifyDbContext otherDb )
    {
        verifyProperties( node, otherNode );
        verifyIndex( node, otherNode, refDb, otherDb );
        Set<Long> otherRelIds = new HashSet<Long>();
        for ( Relationship otherRel : otherNode.getRelationships( Direction.OUTGOING ) )
        {
            otherRelIds.add( otherRel.getId() );
        }
        
        for ( Relationship rel : node.getRelationships( Direction.OUTGOING ) )
        {
            Relationship otherRel = otherDb.db.getRelationshipById( rel.getId() );
            verifyProperties( rel, otherRel );
            if ( rel.getStartNode().getId() != otherRel.getStartNode().getId() )
            {
                throw new RuntimeException( "Start node differs on " + rel );

After Change


    private static int[] verifyNode( Node node, Node otherNode,
            VerifyDbContext refDb, VerifyDbContext otherDb )
    {
        int vNodePropCount = verifyProperties( node, otherNode );
        int vNodeIndexPropCount = verifyIndex( node, otherNode, refDb, otherDb );
        Set<Long> otherRelIds = new HashSet<Long>();
        for ( Relationship otherRel : otherNode.getRelationships( Direction.OUTGOING ) )
        {
            otherRelIds.add( otherRel.getId() );
        }
        
        int vRelCount = 0;
        int vRelPropCount = 0;
        for ( Relationship rel : node.getRelationships( Direction.OUTGOING ) )
        {
            Relationship otherRel = otherDb.db.getRelationshipById( rel.getId() );
            vRelPropCount += verifyProperties( rel, otherRel );
            if ( rel.getStartNode().getId() != otherRel.getStartNode().getId() )
            {
                throw new RuntimeException( "Start node differs on " + rel );
            }
            if ( rel.getEndNode().getId() != otherRel.getEndNode().getId() )
            {
                throw new RuntimeException( "End node differs on " + rel );
            }
            if ( !rel.getType().name().equals( otherRel.getType().name() ) )
            {
                throw new RuntimeException( "Type differs on " + rel );
            }
            otherRelIds.remove( rel.getId() );
            vRelCount++;
        }
        
        if ( !otherRelIds.isEmpty() )
        {
            throw new RuntimeException( "Other node " + otherNode + " has more relationships " +
                    otherRelIds );
        }
        return new int[] { vRelCount, vNodePropCount, vRelPropCount, vNodeIndexPropCount };
    }

    private static int verifyIndex( Node node, Node otherNode, VerifyDbContext refDb,